Skip to content

Conversation

fnKode
Copy link
Contributor

@fnKode fnKode commented Sep 25, 2024

  • Removed trailing slash from the url in request.ts:
    from
    const url = `${config.BASE}${path}` + (path.endsWith('/') ? '' : '/');
    to
    const url = `${config.BASE}${path}`;
    This fixes an issue where requests to the mAPI would fail due to the trailing slash.
  • Updated the wrapper to use mAPI version 1.33.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024

🦋 Changeset detected

Latest commit: 8eaaabb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/mad-maintenance-api-ts-wrapper Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fnKode fnKode requested a review from HaakonSvane September 25, 2024 13:14
Copy link
Collaborator

@HaakonSvane HaakonSvane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fresh 🔥

@fnKode fnKode merged commit 222be81 into main Sep 26, 2024
5 checks passed
@fnKode fnKode deleted the update-wrapper-to-1.33.0 branch September 26, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants